Uploaded image for project: 'JOC - JS7 Operations Center'
  1. JOC - JS7 Operations Center
  2. JOC-2138

GUI should consider quoting in variable assignments of Node Properties

    XMLWordPrintable

Details

    • Fix
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 2.8.1
    • 2.8.2
    • JOC Cockpit GUI
    • None

    Description

      Current Situation

      • Wrong: unquoted string input to Node Properties of jobs is not added proper quotes when persisted to JSON. The resulting JSON is invalid and cannot be deployed.
        • GUI Input:
          YADE Profile = copy_localToWebshop6
          target_dir = /var/www/shared/files/imports/import_cable_explorer_json\
          
        • JSON:
          "defaultArguments": {
              "yadeProfile": "'copy_localToWebshop6'",
              "target_dir": "/var/www/shared/files/imports/import_cable_explorer_json"
          }
          
      • Wrong: double-quoted string input to Node Properties of jobs is not persisted to JSON as double-quotes are removed. This is results in invalid JSON that cannot be deployed.
        • GUI Input:
          YADE Profile = "copy_localToWebshop6"
          target_dir = "/var/www/shared/files/imports/import_cable_explorer_json\"
          
        • JSON:
          "defaultArguments": {
              "yadeProfile": "'copy_localToWebshop6'",
              "target_dir": "/var/www/shared/files/imports/import_cable_explorer_json"
          }
          
      • Right: Single-quoted string input to Node Properties of jobs is persisted to JSON:
        • GUI Input:
          YADE Profile = 'copy_localToWebshop6'
          target_dir = '/var/www/shared/files/imports/import_cable_explorer_json\'
          
        • JSON:
          "defaultArguments": {
              "yadeProfile": "'copy_localToWebshop6'",
              "target_dir": "'/var/www/shared/files/imports/import_cable_explorer_json'"
          }
          

      Workaround

      • Users can apply single quotes

      Desired Behavior

      • Unquoted string input should be persisted using quotes in JSON. This does not apply to numeric and Boolean values and it does not apply to functions and variable references.
      • Double-quoted string input should be persisted using the quotes entered by the user.
      • Single-quoted string input is handled fine and remains unchanged.

      Attachments

        Activity

          People

            ZtRahul193 Rahul Patidar
            ap Andreas Püschel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: