When adding add hoc orders to a job chain with file_sinks no orders will be executed any more

Current Situation

• Job chains configured for use with file order sources expect file orders, not ad hoc orders. It is a user error to add an ad hoc order to such a job chain. However, the GUI does not prevent a user from doing so.
• When using a file order source and file order sink for a job chain and adding an ad hoc order to the job chain then the order will not complete and will be stuck in the file order sink that stops to work. After this, no other order (even for other job chains) will be executed until the JobScheduler Master will be restarted.
• Also after the above problem occurred when adding a file to the file order source directory then no order will be created.
• The default process class includes all the list entries for the file sink order. Review the attached screenshot JOC-1041.png for reference.

• The order log shows this block ~500 times.

  2020-10-29 14:34:24.272+0100 [info]   Task scheduler_file_order_sink:352909 - Protocol starts in D:/documents/sos-berlin.com/scheduler_joc_cockpit/logs/task.scheduler_file_order_sink.log
  2020-10-29 14:34:24.273+0100 [info]   SCHEDULER-726  Task runs on this JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.273+0100 [info]   SCHEDULER-918  state=starting (at=never)
  2020-10-29 14:34:24.276+0100 [WARN]   SCHEDULER-343 This is no file order: Order ('2073')
  2020-10-29 14:34:24.276+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.276+0100 [ERROR]  SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.276+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.277+0100 [ERROR]  SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.277+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.277+0100 [ERROR]  detach_order_after_error: SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.277+0100 [ERROR]  SCHEDULER-191  separate_process: Unexpected state _operation==NULL in step
  2020-10-29 14:34:24.277+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.277+0100 [ERROR]  SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.277+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.277+0100 [ERROR]  detach_order_after_error: SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.277+0100 [info]   SCHEDULER-843  Task has ended processing of Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444'
  2020-10-29 14:34:24.277+0100 [ERROR]  finish(): SCHEDULER-149  There is no job in job chain "/filesink/job_chain1" for the state "DISP_E_PARAMNOTFOUND (missing value)"
  2020-10-29 14:34:24.278+0100 [info]   SCHEDULER-918  state=closed
  2020-10-29 14:34:24.286+0100 [info]   SCHEDULER-842  Task is going to process Order filesink/job_chain1:2073, state=success, on JobScheduler 'http://LAPTOP-7RSACSCV:40444', Order's Process_class
  

How to Reproduce

• Unzip the attached configuration to the ./live folder.
• Adjust the directory for file order source.
• Add the order from the action menu of the job chain.
• Add a file to the file order source directory.

Note: After this, no other orders will execute in the Master.

Desired Behavior

• Users should not add ad hoc orders to job chains configured for file order sources.
• The GUI should prevent users from adding orders to such job chains.

Maintainer Notes

• Job chains that make use of a file order source are intended for file watching. It is a user error to add an ad hoc order to such a job chain that makes use of a file order sink. The problem occurs when the file order sink is executed without a file being present.
• Therefore, if job chains with a file order source should be used for both purposes to watch for incoming files and to accept ad hoc orders then they are not allowed to use a file order sink. Instead, remove the incoming file with one of the jobs in that job chain.