Uploaded image for project: 'JS - JobScheduler'
  1. JS - JobScheduler
  2. JS-1785

Change to a holidays file that is included in a schedule triggers an infinite loop

    XMLWordPrintable

    Details

    • Type: Fix
    • Status: Released (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12
    • Fix Version/s: 1.12.6
    • Component/s: None
    • Labels:
      None

      Description

      Current Situation

      • User has multiple schedules which include a holiday file from live folder. example below
        <?xml version="1.0" encoding="ISO-8859-1"?>
        <schedule >
            <weekdays >
                <day  day="1 2 3 4 5">
                    <period  single_start="06:30" when_holiday="next_non_holiday"/>
                </day>
            </weekdays>
            <holidays >
                <include  live_file="market_holidays.xml"/>
            </holidays>
        </schedule>
        
      • The holiday's file is updated manually or by other job.
        <?xml version="1.0" encoding="iso-8859-1"?>
        <holidays>
           <holiday  date="2018-07-14"/>
           <holiday  date="2018-07-15"/>
           <holiday  date="2018-07-21"/>
           <holiday  date="2018-07-22"/>
           <holiday  date="2018-07-28"/> 
        </holidays>
        
      • Ever night when the holiday file is generated, the change in the holiday file force the scheduler to change the schedules to
        .16 18:48:42.953     3 24463.B54854C0 {scheduler} sos::scheduler::include::Has_includes::changed_included_file_info /home/docker/sos-berlin.com/jobscheduler/jobscheduler12/config/live/Ticket#2018081410000023/market_holidays.xml 2018-08-16 16:29:46.000Z, was 2018-08-16 16:48:33.000Z
        
      • The update of holidays xml file trigger a infinte loop where every minute the schedules are updated.
      • Refer debug log file scheduler.zip ( line number 2892 to 3206)

      How to Reproduce

      • Deploy the attached example Ticket#2018081410000023.zip in the live folder.
      • Open the holiday file, insert a space at end of the file and save it.
      • JobScheduler will keep reading the schedules, again and again, every minute.

      Desired Behavior

      • Change in the holiday file should not start an infinite loop

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jz Joacim Zschimmer
                Reporter:
                mp Mahendra Patidar
                Approver:
                Mahendra Patidar
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: