JOC - JobScheduler Operations Center
  1. JOC - JobScheduler Operations Center
  2. JOC-551

JOC Audit log api name ./job_chain_nodes/activate does not correspond to operation "skip"

    Details

      Description

      Current Situation

      • When the user perform some intervention in the JOC Cockpit, a audit log entry is added to the JOC audit log with API being called and parameters.
      • In the JOC Audit Log
        • for the job operation stop the API ./jobs/stop is called, similarly for the operation unstop,
        • for the job node operation skip the API ./job_chain_nodes/skip is called
        • but for the job node operation unskip the API ./job_chain_nodes/activate is called - which does not correspond to the name of the operation.
      • 2018-09-27 09:58:47,935 INFO  REQUEST: ./job_chain_nodes/skip - USER: root - PARAMS: {"jobChain":"/ParallelExec/job_chain1","node":"splitL1:230","jobschedulerId":"jobscheduler12_4412"} - COMMENT: Ticket#2018092510000055 - TIMESPENT: - - TICKET: -
        2018-09-27 09:58:59,325 INFO  REQUEST: ./job_chain_nodes/activate - USER: root - PARAMS: {"jobChain":"/ParallelExec/job_chain1","node":"splitL1:230","jobschedulerId":"jobscheduler12_4412"} - COMMENT: Ticket#2018092510000055 - TIMESPENT: - - TICKET: -
        2018-09-27 09:59:10,111 INFO  REQUEST: ./jobs/stop - USER: root - PARAMS: {"job":"/ParallelExec/splitL2","jobschedulerId":"jobscheduler12_4412"} - COMMENT: Ticket#2018092510000055 - TIMESPENT: - - TICKET: -
        2018-09-27 09:59:21,306 INFO  REQUEST: ./jobs/unstop - USER: root - PARAMS: {"job":"/ParallelExec/splitL2","jobschedulerId":"jobscheduler12_4412"} - COMMENT: Ticket#2018092510000055 - TIMESPENT: - - TICKET: -
        

      Desired Situation

      • The API names should be consistent with the operations

      Maintainer Notes

      • API methods names generally do not reflect the same wording that the JOC Cockpit offers to users. The method names have been chosen to reflect the API behavior.
      • The observation in the audit log that operation names differ from API names is valid for all users who use JOC Cockpit in other languages than English. We therefore intend to add a new feature JOC-557 that adds explicit operation names to the audit log.

        Issue Links

          Activity

          Hide
          XEOPS Datenbank Admin added a comment - - edited

          In the Maintainer Notes, it is written, "The observation in the audit log that operation names differ from API names is valid for all users who use JOC Cockpit in other languages than English."

          The word "unskip" and the word "activate" are both English words. Our JOC Cockpit is using English as it's preferred language, and we are still seeing this discrepancy. Therefore, the above statement is false. Correct would be this: The observation in the audit log that operation names differ from API names is valid for all users regardless of which language they are using in the JOC Cockpit.

          Why was the Desired Situation abandoned? It makes sense that the audit log, which is meant to be visible by the users, should display the operations using the same wording that the JOC Cockpit offers to users. Users don't care what API name was called in the background.

          I also noticed that there is an error in the Description. When a user uses the operation unSTOP, the audit log is logging this as "activate". There is currently no way to distinguish between unstop and unskip. I can reproduce this in JOC 1.12.4 as well as in 1.12.7.

          Show
          XEOPS Datenbank Admin added a comment - - edited In the Maintainer Notes, it is written, "The observation in the audit log that operation names differ from API names is valid for all users who use JOC Cockpit in other languages than English." The word "unskip" and the word "activate" are both English words. Our JOC Cockpit is using English as it's preferred language, and we are still seeing this discrepancy. Therefore, the above statement is false. Correct would be this: The observation in the audit log that operation names differ from API names is valid for all users regardless of which language they are using in the JOC Cockpit. Why was the Desired Situation abandoned? It makes sense that the audit log, which is meant to be visible by the users, should display the operations using the same wording that the JOC Cockpit offers to users. Users don't care what API name was called in the background. I also noticed that there is an error in the Description. When a user uses the operation unSTOP, the audit log is logging this as "activate". There is currently no way to distinguish between unstop and unskip. I can reproduce this in JOC 1.12.4 as well as in 1.12.7.

            People

            • Assignee:
              Oliver Haufe
              Reporter:
              Mahendra Patidar
              Approver:
              Mahendra Patidar
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: